Ignore --diagnostic-width argument when computing hash
#2424
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shadaj
added a commit
to hydro-project/hydro
that referenced
this pull request
Jul 24, 2025
… to improve caching sccache includes all environment variables starting with `CARGO_` in the cache key, so this would cause misses for all trybuild compilation. Along with mozilla/sccache#2424, this improves compilation caching.
shadaj
added a commit
to hydro-project/hydro
that referenced
this pull request
Jul 24, 2025
… to improve caching (#1943) sccache includes all environment variables starting with `CARGO_` in the cache key, so this would cause misses for all trybuild compilation. Along with mozilla/sccache#2424, this improves compilation caching.
jhellerstein
pushed a commit
to hydro-project/hydro
that referenced
this pull request
Jul 25, 2025
… to improve caching (#1943) sccache includes all environment variables starting with `CARGO_` in the cache key, so this would cause misses for all trybuild compilation. Along with mozilla/sccache#2424, this improves compilation caching.
shadaj
force-pushed
the
ignore-diagnostic-width
branch
from
be74fe5 to
ef0ee4a
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2424 +/- ##
=======================================
Coverage 71.57% 71.58%
=======================================
Files 65 65
Lines 36365 36372 +7
=======================================
+ Hits 26029 26036 +7
Misses 10336 10336 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
shadaj
force-pushed
the
ignore-diagnostic-width
branch
from
ef0ee4a to
e8521b1
Compare
shadaj
force-pushed
the
ignore-diagnostic-width
branch
from
6f7c3cc to
c03937b
Compare
Contributor
Author
|
@sylvestre I think you'll need to approve the GitHub Actions workflow; the linting errors after the original merge should be fixed! |
Collaborator
|
done |
Contributor
Author
|
Looks like the failures are from |
Contributor
Author
|
Friendly bump @sylvestre! The changes should be good to go. |
sylvestre
force-pushed
the
ignore-diagnostic-width
branch
2 times, most recently
from
52fa2aa to
215d25e
Compare
Collaborator
|
Could you please add tests to verify that we aren't regressing in the future? thanks |
Collaborator
|
Very sorry it took that long to get to this |
shadaj
force-pushed
the
ignore-diagnostic-width
branch
from
215d25e to
7ae50e2
Compare
Contributor
Author
|
@sylvestre added the test! And please don't apologize, really appreciate all the work you do as a maintainer :) |
Collaborator
|
thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2418
We ran into this in https://github.com/hydro-project/hydro, where we programmatically invoke Cargo to compile generated Rust sources, so without a TTY the hash of arguments would differ causing cache misses. This ignores that argument, and I validated on Hydro that it enables cache hits in the non-TTY builds.